Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore deprecation warnings coming from upstream gwcs package" #1208

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 20, 2024

Reverts #1200

Fix #1206

@pllim pllim added testing no-changelog-entry-needed changelog bot directive labels Dec 20, 2024
@pllim pllim added this to the v1.x milestone Dec 20, 2024
@pllim pllim marked this pull request as ready for review December 20, 2024 18:30
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (40d4bb5) to head (6846845).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          63       63           
  Lines        4576     4576           
=======================================
  Hits         3977     3977           
  Misses        599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 4f06c27 into main Dec 31, 2024
22 of 23 checks passed
@pllim pllim deleted the revert-1200-ignore-gwcs-warning branch December 31, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Unignore warnings from gwcs when we can
1 participant